Polishing --ignore-patterns change
Review Request #3438 - Created Feb. 8, 2016 and submitted
|benjyw, patricklaw, stuhood, zundel|
In process of OSS pants adoption in Twitter I've discovered couple of problems in
This RB contain couple of fixes:
- do not access deprecated property in
- do not pass explicitly
--ignore-patternsoption name in deprecation message for
I also have another bug to report, at least a deviation from the gitignore behavior. If a top-level folder is added to the ignore-files, it ignores anywhere else that folder name is found.
So if I have
login the ignore-files, it will ignore the BUILD files in com/foursquare/target/module/log/BUILD. I can add
logto the .gitignore file and still have version controlled files under that subdir.
I fell victim to this. It would probably mean going through a deprecation cycle but I would prefer the fix go the other way around, i.e. change the flag to be build_file_ignore_patterns or build_ignore_patterns.
ignore_patternsin the default scope, it is not clear to the uninitiated what it refers to.
Revision 2 (+5 -4)
Status: Closed (submitted)
Merged as 6ba5c33b566be010073593a463fdae617d1bbeb6