Fix project info tests to work when the Ivy cache is overridden.

Review Request #3429 — Created Feb. 5, 2016 and updated

patricklaw
pants
2894, 2895
pants-reviews
benjyw, gmalmquist, jsirois, stuhood
Also mark a jdk8 junit test as expected to fail.
See https://github.com/pantsbuild/pants/issues/2894

These two changes allow integration tests to pass on Jenkins,
provided that the ivy cache is isolated per-build.

Jenkins testing to get integration tests working: http://jenkins.pantsbuild.org/view/Debug/job/debug.pants_ci.integration_tests/11/
Travis is baking: https://travis-ci.org/pantsbuild/pants/builds/107355972

  • 0
  • 0
  • 1
  • 0
  • 1
Description From Last Updated
PA
PA
ST
  1. 
      
  2. Will this mean that this test refetches a bunch of stuff that could have come from the workspace/machine caches instead?

    How much does it affect the runtime for cold builds?

    1. (1) Yes
      (2) As far as I can tell it wasn't noticably bad on Jenkins. These are already super slow integration tests as it is. And this only changes two tests to behave like this, not all of them.

      In any case, unless the perf difference was obnoxious, I think we should favor correctness over performance.

  3. This should likely come from a class @property.

    1. The workdir isn't unified between the two classes. Do you just mean the .ivy_cache magic string?

    2. Made it into a param for the one place where the caller relied on knowing the magic string. In the other code path the string doesn't actually matter, so there was no need to extract it out.

  4. 
      
PA
BE
  1. 
      
  2. It's weird that this use of formatting is inconsistent with the following line. Maybe replace {dir} with {} ?

  3. 
      
PA
Review request changed
ST
  1. Ship It!
  2. 
      
NH
  1. Ship It!
  2. 
      
GM
  1. Ship It!
  2. 
      
Loading...