Cleaning up jarjar rules, and adding support for keep and zap.

Review Request #3428 — Created Feb. 5, 2016 and submitted

gmalmquist
pants
gmalmquist/clean-and-improve-shading
2893
pants-reviews
benjyw, dturner-tw, jsirois, patricklaw
The shading subsystem had some extraneous indirection, which used
to be necessary but now very much isn't.

I also added support for defining `keep` and `zap` rules, which we
now have some use-cases for internally.

Added unit and integration tests to test_shader.py, and manually tested the new keep/zap rules internally.

CI went green here: https://travis-ci.org/pantsbuild/pants/builds/107332277

  • 0
  • 0
  • 1
  • 1
  • 2
Description From Last Updated
DT
  1. 
      
  2. Do we need to deprecate the old ones, or keep them around for a while?

    1. They are still here - just shifted below in the diff.
    2. I don't think we need to deprecate the old ones -- as far as users (writers of BUILD files) are concerned, the existing API hasn't changed, this just adds a couple new things.

  3. nit: space between keep and rule

  4. nit: missing ( between zap and 'package_name

  5. 
      
JS
  1. 
      
  2. I think the example should be using a single * to match the comment text above it.
  3. The comment seems to still hold merit - consider restoring it.
  4. missing '(': s/shading_zap'package_name/shading_zap('package_name/

  5. 
      
GM
JS
  1. Ship It!
  2. 
      
GM
GM
Review request changed

Status: Closed (submitted)

Change Summary:

In 216f00bf468d02ac3f5a4542a0c20650eaeecf79. Thanks David & John!

Loading...