Cleaning up jarjar rules, and adding support for keep and zap.

Review Request #3428 - Created Feb. 5, 2016 and submitted

Information
Garrett Malmquist
pants
gmalmquist/clean-and-improve-shading
2893
Reviewers
pants-reviews
benjyw, dturner-tw, jsirois, patricklaw
The shading subsystem had some extraneous indirection, which used
to be necessary but now very much isn't.

I also added support for defining `keep` and `zap` rules, which we
now have some use-cases for internally.

Added unit and integration tests to test_shader.py, and manually tested the new keep/zap rules internally.

CI went green here: https://travis-ci.org/pantsbuild/pants/builds/107332277

Issues

  • 0
  • 1
  • 1
  • 2
Description From Last Updated
David Turner
John Sirois
Garrett Malmquist
John Sirois
Garrett Malmquist
Garrett Malmquist
Review request changed

Status: Closed (submitted)

Change Summary:

In 216f00bf468d02ac3f5a4542a0c20650eaeecf79. Thanks David & John!

Loading...