Retain file permissions when shading monolithic jars.

Review Request #3420 - Created Feb. 4, 2016 and submitted

Information
Garrett Malmquist
pants
gmalmquist/fix-shaded-jar-permissions
2885
Reviewers
pants-reviews
benjyw, nhoward_tw, stuhood
On some systems (macos at least), the atomic_copy function at the
end of the jar shading process would cause the file permissions to
be set to '-rw-------', instead of the normal '-rw-r--r--', because
of the permissions of the temporary file that atomic_copy creates.

This change simply records the permissions of the jar before
shading, and chmod's the shaded jar to have whatever permissions it
had previously.

Added an integration test to test_shader_integration.py.

CI went green here: https://travis-ci.org/pantsbuild/pants/builds/107310100

Issues

  • 0
  • 2
  • 0
  • 2
Description From Last Updated
Nick Howard (Twitter)
Stu Hood
Nick Howard (Twitter)
Benjy Weinberger
Garrett Malmquist
Benjy Weinberger
Garrett Malmquist
Garrett Malmquist
Review request changed

Status: Closed (submitted)

Change Summary:

In commit 37fdcb7d35b8673223ae77a5747c678b8e4c13d5. Thanks Stu, Nick, and Benjy!

Loading...