Cleanup: rename ivy_resolve kwarg custom_args to extra_args; move / rm unnecessary conf or defaults; rm unnecessary extra_args

Review Request #3416 — Created Feb. 3, 2016 and submitted

nhoward_tw
pants
2882
pants-reviews
benjyw, jsirois, stuhood, zundel

I noticed a few unused passed empty arguments, duplicated defaulting to default and inconsistent kwarg names. This cleans up some calls, removes duplicated conf logic and removes conf logic that is never exercised.

CI passed https://travis-ci.org/pantsbuild/pants/builds/106793750

  • 0
  • 0
  • 1
  • 0
  • 1
Description From Last Updated
PA
  1. 
      
  2. I'd prefer to see the extra_args defaulting happen in the idiomatic way at the beginning of the method (extra_args = extra_args or []) rather than buried in an awkward ternary here.

  3. 
      
NH
ST
  1. Ship It!
  2. 
      
NH
Review request changed

Status: Closed (submitted)

Change Summary:

Thanks folks, https://github.com/pantsbuild/pants/commit/5420cb4c49a073f44c282df02eada7c8b11017fb

Loading...