bug fix: is_app filter not applied when using wildcard

Review Request #3398 - Created Jan. 30, 2016 and submitted

Information
Peiyu Wang
pants
2863
Reviewers
pants-reviews
kwlzn, nhoward_tw, patricklaw, stuhood, zundel

This is an annoying bug introduced by https://rbcommons.com/s/twitter/r/3272/.

./pants bundle timelineservice/server:
...
Exception message: Target(BuildFileAddress(BuildFile(/some_source_root/path/BUILD, FileSystemProjectTree(/some_source_root/)), server)) is not a valid app target

Because wildcard includes non jvm_app, jvm_binary targets.

To preserve existing user experience, target_root is used when
use_basename_prefix is set. We should apply the same is_app filter for
those target_roots, same way as we apply is_app to targets().

https://travis-ci.org/pantsbuild/pants/builds/105929290 passed

Issues

  • 0
  • 1
  • 0
  • 1
Description From Last Updated
Eric Ayers
Peiyu Wang
Nick Howard (Twitter)
Peiyu Wang
Peiyu Wang
Review request changed

Status: Closed (submitted)

Change Summary:

Submitted as 97f0fb41b63cac3e1c1cc9dcdac7edd401933418

Loading...