Add validations to jvm_app bundles; Fix typo in BundleProps construction; fix relative globs

Review Request #3396 — Created Jan. 30, 2016 and submitted

nhoward_tw
pants
2861
pants-reviews
benjyw, dturner-tw, jsirois, zundel

While doing a release, we found a bug in the recent performance changes in bundle handling. This fixes that bug as well as a bug in generating globs from the build root. It also adds validations around input combinations that will fail to work as expected.

Validations:

  • Ensure fileset is one of the expected types.
  • If rel_path is specified with a glob, raise an error.

Fixes
Ensure that a passed rel_path overrides the default one from the parse context.
when globs_relative_to_buildroot is used, ensure that non-glob filesets have the correct paths returned.

Wrote regression tests and made them pass. CI away on the pull request.

ci passed at https://travis-ci.org/pantsbuild/pants/builds/106309237

DT
  1. Ship It!
  2. 
      
BE
  1. 
      
  2. Can you explain why here (either in the error message or in a comment, whichever you think is more appropriate), like you do in the test? ("Globs are treated as eager...")

  3. 
      
NH
BE
  1. Ship It!
  2. 
      
NH
NH
NH
NH
Review request changed

Status: Closed (submitted)

Change Summary:

https://github.com/pantsbuild/pants/commit/937239a2ac45a4bd6482145c673416e5d80659d1

Loading...