Add and use an invalidation-local use_cache setting in IvyTaskMixin

Review Request #3386 — Created Jan. 28, 2016 and submitted

stuhood
pants
1640, 2850
pants-reviews
nhoward_tw, patricklaw

This change makes it possible to enable remote caching for bootstrap.bootstrap-jvm-tools (ie, tool shading), by disabling caching entirely for the invalidation check that surrounds ivy resolves in IvyTaskMixin.

  • Add and use use_cache=False to skip cache checks for IvyTaskMixin.
  • Add a test that ensures that ivy resolves no longer cache.

https://travis-ci.org/pantsbuild/pants/builds/105485021

NH
  1. LGTM. I've been wanting to rm the raw_classpath caching. I figured I'd get to it as part of breaking out resolve / fetching. Thanks for picking it up.

    I'd like to see a unit test for Task.invalidated for the new behavior, but I see that it doesn't really have unit tests at the moment.

  2. 
      
ST
Review request changed

Status: Closed (submitted)

Change Summary:

Merged as b7f497f0db6ea5f1b6a5ef29077bfab52693af0b

PA
  1. Ship It!
  2. 
      
Loading...