BuildFile refactoring: add more constraints to BuildFile constructor

Review Request #3376 - Created Jan. 26, 2016 and submitted

Information
Timur Abishev
pants
tabishev/build_file_strict_mode
2838
Reviewers
pants-reviews
dturner-tw, patricklaw, stuhood, zundel

BuildFile.__init__ used to try to find any BUILD file in a passed directory and use it. Now it requires that an explicit (existing) BUILD file is passed in order to succeed.

Previous behaviour doesn't work well with future pants_build_ignore option because this option can forbid some BUILD files extensions.

This RB adds the constraint to BuildFile constructor: input path should be a path to an existing BUILD file only.

https://travis-ci.org/ttim/pants/builds/105066148

Issues

  • 0
  • 7
  • 0
  • 7
Description From Last Updated
Timur Abishev
Timur Abishev
Timur Abishev
Timur Abishev
Eric Ayers
Patrick Lawson
Timur Abishev
Eric Ayers
Timur Abishev
Patrick Lawson
Patrick Lawson
Timur Abishev
Timur Abishev
Timur Abishev
Review request changed

Status: Closed (submitted)

Change Summary:

c88c53784a10d33065adb895724d76afae8289b9

Loading...