Refactor IvyTaskMixin's ivy_resolve and functions it depends on

Review Request #3371 - Created Jan. 26, 2016 and submitted

Information
Nick Howard (Twitter)
pants
2828
Reviewers
pants-reviews
benjyw, gmalmquist, stuhood, zundel
  • Simplify and document IvyUtils.calculate_classpath
  • Remove unnecessary conf or ('default')s
  • extract portion of _exec_ivy to IvyUtils
  • Make cachepath return rather than yield. It already reads the full file, so it should have no memory impact.
  • Rename cachepath to be more descriptive.
  • Group variable usage with declarations in ivy task mixin

Ran unit tests. Successful travis at https://travis-ci.org/pantsbuild/pants/builds/104766229

Eric Ayers
Benjy Weinberger
Benjy Weinberger
Garrett Malmquist
Benjy Weinberger
Nick Howard (Twitter)
Review request changed

Status: Closed (submitted)

Change Summary:

https://github.com/pantsbuild/pants/commit/8307ec95a1ab13bbe6dbc0662ec2a04e36d20a9e

Loading...