BuildFile refactoring: remove usages and deprecate of BuildFile's family, ancestors, siblings and descendants methods
Review Request #3368 — Created Jan. 23, 2016 and submitted
|dturner-tw, patricklaw, stuhood, zundel|
In order to implement
pants_build_ignoreoption I need to have as less as possible places where I need to pass this option to.
This RB remove usages/deprecate all returning
BuildFiles methods except
BuildFilewhich sounds like sufficient interface to get
BuildFiles in general.
Have you double checked with all of the relevant parties whether this is an okay deprecation cycle? It's pretty aggressive.
I think 4sq is fine with this, but you should check with Square and whoever you need to at Twitter in case you haven't.
Unfortunate to see "private" access here. Should
address_mapperexpose an interface for this purpose? It doesn't have to explicitly talk about BUILD files, it could just abstract it away to talk about non-empty spec paths (which in this case happens to always correspond to a BUILD file, but in the future it might be more abstract).
Revision 3 (+201 -225)