build_file_alias Perf Improvement: Move class declaration out of method target_macro

Review Request #3361 - Created Jan. 21, 2016 and submitted

Information
Nick Howard (Twitter)
pants
2822
Reviewers
pants-reviews
benjyw, stuhood

target_macro is called once for each macro for each BUILD file. If you have a lot of build files and a lot of macros, it can become expensive to declare large numbers of classes. This moves the declaration out of the method, so it will only be defined once.

Ran unit tests locally, ci in progress.

Stu Hood
Benjy Weinberger
Nick Howard (Twitter)
Nick Howard (Twitter)
Review request changed

Status: Closed (submitted)

Change Summary:

submitted at https://github.com/pantsbuild/pants/commit/58d59d3f9ae891494ed0e66f239c2de183ea4308

Loading...