Group classpath products by their targets
Review Request #3338 - Created Jan. 14, 2016 and submitted
|nhoward_tw, patricklaw, stuhood, zundel|
This review adds the convenient method
ClasspathProductsto return products or classpath
products associated with their targets.
This is so that we can look up products for the targets their belong to.
https://rbcommons.com/s/twitter/r/3329/ attempts to create 3rdparty libraries
symlinks same way as internal libraries are created, for bundle. There are two
- get the classpath products for all targets in
- make the same call multiple times for each target
The issue with (2) is it does not respect the excludes same as (1), because
excludes are transitive to their dependents.
This review will allow us after calling
target.idfor each products and make symlinks accordingly.
because excludes are global.
More specifically, excludes are transitive to their dependents.
I think the comment is incorrect. The dict groups by product, with the list of targets providing that product..?
Rather than grouping these in ordered dictionaries here, it seems like it might be easier to return them as tuples of (product, target), and to then let callers do the group if they want to.
More accurate description for excludes
Revision 2 (+80 -34)
Address Stu's comments
get_product_target_mappings_for_targetsreturn (product, target) tuples
Revision 3 (+92 -30)