Turn on redirects when retrieving a URL in the fetcher API

Review Request #3317 - Created Jan. 8, 2016 and submitted

Information
Eric Ayers
pants
https://travis-ci.org/pantsbuild/pants/builds/100944456
2781
ef48000...
Reviewers
pants-reviews
gmalmquist, nhoward_tw, stuhood

Simple change to allow redirects in the requests.get() call.

Motivation: At Square, we have a proxy server that serves up tool artifacts. It works by
sending redirects with special arguments for authentication passed in to the redirect, so we require
that HTTP fetching follows redirects just as it did before https://rbcommons.com/s/twitter/r/3275

CI green at https://travis-ci.org/pantsbuild/pants/builds/101039903
Added a unit test that makes sure redirects are respected.
Tested manually in Square's repo

Issues

  • 0
  • 2
  • 0
  • 2
Description From Last Updated
Garrett Malmquist
Eric Ayers
Eric Ayers
Eric Ayers
Review request changed

Status: Closed (submitted)

Change Summary:

Thanks Garrett. Commit 4e5b341

Eric Ayers

   
tests/python/pants_test/testutils/BUILD (Diff revision 2)
 
 

this is unrelated to the rest of my change, but fixed running unit tests locally.

Loading...