Simplify build dict/reference information extraction.

Review Request #3301 - Created Jan. 5, 2016 and submitted

Information
Benjy Weinberger
pants
Reviewers
pants-reviews
lahosken, zundel

Previously we had various non-standard ways of providing
BUILD file objects and context-aware object factories: Some
were objects with __call__ methods, some were functions, some
were the results of currying the context arg.

All this made it difficult to introspect on these to identify
the args and docstrings used to generate the build dictionary.

It also required various manual builddict annotations that it
would be better to avoid.

This change standardizes how these objects are provided, and makes
corresponding changes to the info extracters to take advantage
of this.

It also removes the old source_root BUILD file directive, as those are
no longer supported.

A future change will use this to rewrite the build dictionary/reference
page generator, so we can get rid of reflect.py.

CI passes: https://travis-ci.org/pantsbuild/pants/builds/100417620

Issues

  • 0
  • 1
  • 0
  • 1
Description From Last Updated
Larry Hosken
Eric Ayers
Stu Hood
Eric Ayers
Benjy Weinberger
Benjy Weinberger
Benjy Weinberger
Review request changed

Status: Closed (submitted)

Change Summary:

Submitted at revision #2 (#3 was a diff belonging to another change that was uploaded here by mistake), as f04ad7d453c21c3d6613f105e963c3187f1c37bd.

Loading...