Save details on exceptions encountered to a file

Review Request #3289 - Created Jan. 2, 2016 and submitted

Information
Eric Ayers
pants
zundel/save-exception-stacktrace
2762
0aca913...
Reviewers
pants-reviews
benjyw, gmalmquist, kwlzn, stuhood

The last exception is new always appended to a file .pants.d/logs/exceptions.log

CI is running at https://travis-ci.org/pantsbuild/pants/builds/100384280

Added a unit test.

Manual testing by inserting an exception demonstrates it creates a formatted file:

args: ['/Users/zundel/Src/Pants/src/python/pants/bin/pants_exe.py', 'test', 'tests/python/pants_test/bin:exiter']
pid: 59910
timestamp: 2016-01-02T09:28:25.935156

Exception caught: (<type 'exceptions.ValueError'>)
  File "/Users/zundel/Src/Pants/src/python/pants/bin/pants_exe.py", line 32, in <module>
    main()
  ...
    return cls.prepare(cls._scoped_options(options), round_manager)
  File "/Users/zundel/Src/Pants/src/python/pants/backend/jvm/tasks/jvm_compile/zinc/zinc_compile.py", line 173, in prepare
    raise ValueError("Eric, you should have caught this")

Exception message: Eric, you should have caught this

Issues

  • 0
  • 1
  • 0
  • 1
Description From Last Updated
Eric Ayers
Benjy Weinberger
Eric Ayers
Eric Ayers
Benjy Weinberger
Garrett Malmquist
Kris Wilson
Eric Ayers
Eric Ayers
Kris Wilson
Eric Ayers
Review request changed

Status: Closed (submitted)

Change Summary:

Thanks Benjy, Garrett & Kris! Commit 2bafece

Loading...