Allow specification of extra env vars for junit_tests runs.

Review Request #3267 - Created Dec. 17, 2015 and submitted

Information
Garrett Malmquist
pants
gmalmquist/junit-tests-env-vars
2382, 2736
Reviewers
pants-reviews
benjyw, zundel

I added an `extra_env_vars` parameter to junit_tests in much the
same way that apaulin previously added extra_jvm_options previously
in https://rbcommons.com/s/twitter/r/3140.

I cleaned up code in junit_run.py a little (partitioning the tests
by workdir, platform, jvm options, and env vars can all easily be
handled by the existing functionality of _tests_by_properties()
just by passing a couple extra parameters).

Tests added to test_junit_run.py.

CI went green here: https://travis-ci.org/pantsbuild/pants/builds/97500339

Issues

  • 0
  • 1
  • 0
  • 1
Description From Last Updated
Nick Howard (Twitter)
Garrett Malmquist
Eric Ayers
Benjy Weinberger
Nick Howard (Twitter)
Alan Paulin
Garrett Malmquist
Garrett Malmquist
Review request changed

Status: Closed (submitted)

Change Summary:

In commit 7fddcc5d68272a03e9a2b4224b8da728d35eabb2. Thanks Eric, Benjy, Nick, and Alan!

Loading...