WIP: Use target ID instead of basename for bundle dist dir

Review Request #3250 - Created Dec. 14, 2015 and discarded

Information
Karin Lundberg
pants
Reviewers
peiyu, stuhood

Problem

When "./pants bundle" runs for both root targets and dependencies, you might run into issue if you have a jvm_app depending on a jvm_binary and both use the same basename as the basename is use as the destination directory.

Solution

Instead of using basename for the destination directory for the bundle, use the target id as it will always be unique.

Note:
This is WIP. Sending this out now to get feedback on general approach and potential side effects. The potential side effects are best illustrated by the changes needed to make the tests in tests/python/pants_test/targets/test_jvm_app_integration.py pass.

./pants test tests/python/pants_test/targets:jvm_app_integration

Karin Lundberg
Karin Lundberg
Karin Lundberg
Peiyu Wang
Peiyu Wang
Karin Lundberg
Review request changed

Status: Discarded

Change Summary:

See https://rbcommons.com/s/twitter/r/3272/

Loading...