Move registration of basic build file constructs.

Review Request #3246 — Created Dec. 14, 2015 and submitted

benjyw
pants
pants-reviews
kwlzn, zundel
They clearly are not part of any backend, and they aren't
tasks (so they don't belong in core_tasks), so they
 now go in build_graph, which is where almost all the code
that implements them lives.

Moved wrapped_globs.py from backend/core to source, as that
seemed like a more apt place for it than build_graph.

They deal with finding source files on disk, so the source
package is a perfect place for them.

CI passes: https://travis-ci.org/pantsbuild/pants/builds/96646223

  • 1
  • 0
  • 1
  • 0
  • 2
Description From Last Updated
nit: whitespace ZU zundel
ST
  1. Ship It!
  2. 
      
KW
  1. afaict, lgtm!

  2. maybe this docstring could benefit from the :param: treatment?

  3. should this move to __call__ and get the :returns: treatment?

  4. 
      
BE
BE
  1. Thanks folks. Submitted as 926d525422feafbe5598b8e1130eaf5407be7617.

  2. 
      
BE
Review request changed

Status: Closed (submitted)

Change Summary:

926d525422feafbe5598b8e1130eaf5407be7617

ZU
  1. I didn't get a chance to take a very close look at this yet, but I agree with the rationale behind the moves.

  2. nit: whitespace

  3. 
      
Loading...