Add formatting of choices to help output

Review Request #3241 - Created Dec. 12, 2015 and submitted

Information
Eric Ayers
pants
zundel/add-choices-to-help
2691, 2709
73a9b13...
Reviewers
pants-reviews
benjyw, lahosken

A few options offer a constrained set of choices, but the help did not list what those choices were.

In all cases currently, the list is fairly short, so I opted to just add them into the green text on the first line of the option help that currently shows the default choice.

Old output was:

./pants help changed
...
--changed-include-dependees=<str> (default: none)
    Include direct or transitive dependees of changed targets.

New output is:

--changed-include-dependees=<str> (one of: [none, direct, transitive] default: none)
    Include direct or transitive dependees of changed targets.

CI is green at https://travis-ci.org/pantsbuild/pants/builds/96493451
Manual testing, added unit test.

Issues

  • 0
  • 1
  • 0
  • 1
Description From Last Updated
Larry Hosken
Benjy Weinberger
Eric Ayers
Benjy Weinberger
Eric Ayers
Review request changed

Status: Closed (submitted)

Change Summary:

Thanks Benjy & Larry! Commit 2b31210

Loading...