Make jvm_compile's subsystem dependencies global to fix ignored options

Review Request #3238 - Created Dec. 12, 2015 and submitted

Information
Stu Hood
pants
2696
Reviewers
pants-reviews
benjyw, gmalmquist, zundel

This change addresses the issue that the --scala-platform-compile-zinc-fatal-warnings and --java-compile-zinc-fatal-warnings options are registered/recognized, but never used. Rather than actually using a task-specific instance of the subsystem, jvm_compile uses the global instance, and probably should.

  • Made JvmCompile's subsystem dependencies global, and moved from the deprecated task_subsystem/global_subsystem API to the scoping API
  • Added a negative test to confirm that passing the option in the incorrect position explodes
  • Fixed a bug in subsystem_dependencies_iter where the scope of global options was incorrect, which caused them not to be fingerprinted
  • Added a TODO to track #2739, which was discovered here

https://travis-ci.org/pantsbuild/pants/builds/97571757

Issues

  • 0
  • 1
  • 0
  • 1
Description From Last Updated
Stu Hood
Benjy Weinberger
Eric Ayers
Eric Ayers
Stu Hood
Eric Ayers
Stu Hood
Review request changed

Status: Closed (submitted)

Change Summary:

Merged as 1de06d294954cd7c1bff135b8bb8ef0faa64cf9c

Loading...