Remove the need to specify scala tools in BUILD.tools

Review Request #3225 - Created Dec. 10, 2015 and submitted

Information
Matt Olsen
pants
2534, 2730
Reviewers
pants-reviews
patricklaw, stuhood
  • Pull in the scala runtime and compiler based on the scala version specified
  • Inject the runtime's synthetic target into the buildgraph

Testing:

./pants compile examples/src/scala:: (still works after changes)

Testing:

./pants compile examples/src/scala:: (still works after changes)

https://travis-ci.org/pantsbuild/pants/builds/97112835 [green]

Issues

  • 0
  • 23
  • 0
  • 23
Description From Last Updated
Matt Olsen
Eric Ayers
Benjy Weinberger
Stu Hood
Benjy Weinberger
Matt Olsen
Patrick Lawson
Patrick Lawson
Matt Olsen
Stu Hood
Matt Olsen
Matt Olsen
Matt Olsen
Patrick Lawson
Patrick Lawson
Nick Howard (Twitter)
Nick Howard (Twitter)
Kris Wilson
Matt Olsen
Review request changed

Status: Closed (submitted)

Change Summary:

submitted at f65fae2037ce983a25c880601a1a3585ba465104

Mateo Rodriguez

So we are upgrading and found that in scala_platform, the --runtime option removed in scala_platform but no deprecation notice and nothing in the migration script.
https://github.com/pantsbuild/pants/commit/f65fae2037ce983a25c880601a1a3585ba465104#diff-b9d73d5becce91c5c206fcc520265f9cL27
This could silently downgrade the runtime for a 2.11 repo. It is a little late but could you add this to the migration script, if not return it for a deprecation cycle?

Loading...