A couple of tweaks to reporting output.

Review Request #322 — Created May 7, 2014 and submitted

benjyw
pants
pants-reviews
patricklaw
1. Handle ansi escape sequences better. Previously we would render

  \033[36m bar \033[1m baz \033[0m

   as

   <span class="ansi-36"> bar </span><span class="ansi-1"> baz </span>

   Now we correctly nest it as

   <span class="ansi-36"> bar <span class="ansi-1"> baz </span></span>

   This is important because, e.g., \033[1m means "bold text", so we
   need to keep whatever color we had.

2. Make sure unindented console output starts on a new line


LA
  1. 
      
  2. I sure have to think hard to figure out this regexp... and even now that (I think) I know what it does, I don't know why. Maybe add a comment w/motivating examples of things you do/don't want to match? 
  3. 
      
PA
  1. 
      
  2. Trying to reason about this is very difficult.  I'm going to assume that you tested and there aren't any lurking off-by-one errors.
  3. 
      
PA
  1. Ship It!
  2. 
      
BE
Review request changed

Status: Closed (submitted)

Loading...