Create a core_tasks top-level dir.

Review Request #3197 — Created Dec. 1, 2015 and submitted

benjyw
pants
pants-reviews
jsirois, stuhood, zundel

Put a few of the backend/core tasks in it.

Puts some of their base classes/mixins into task/ as they are
not themselves tasks, and are intended to be reusable.

Note that there are no references to these tasks outside pantsbuild,
so it's safe to move them without a deprecation cycle.

CI passes: https://travis-ci.org/pantsbuild/pants/builds/94081549

ZU
  1. 
      
  2. nit date

    1. These were all existing files that I moved and in some cases modified. But the basic authorship is not new. Is it customary to change the dates in such a situation? I really have no idea how such things work.

    2. Don't bother, but whenever I create a new file I update the timestamp, just like you did for the BUILD files.

    3. I'm happy to do it if it's necessary, but I wonder if it's actually a bad idea, because surely the purpose of the date is to establish the IP rights as early as possible?

    4. I think it depends on whether you are trying to defend the age of the code (say for a patent), or trying to extend the copyright protection as long as possible. Anyway, we have git history, I don't think we should worry much about it. I'll try to refrain from commenting on this in the future.

    5. I just consulted a lawyer-type person, and indeed we want the earliest date, for the intended purpose of copyright notices.

    6. Well, you should definitely comment if new code has an old date, because that file would be lying... But for existing code that has merely been refactored, it seems like the older date is the correct choice from a legal consistency standpoint. At least, that is my understanding.

  3. src/python/pants/core_tasks/noop.py (Diff revision 1)
     
     

    nit date

  4. src/python/pants/core_tasks/register.py (Diff revision 1)
     
     

    nit date

  5. nit date

  6. 
      
NH
  1. Ship It!
  2. 
      
BE
  1. Thanks Eric! Submitted as 4562b46b5053877bba0a283a844d62d8c65385ff.

  2. 
      
BE
Review request changed

Status: Closed (submitted)

Change Summary:

4562b46b5053877bba0a283a844d62d8c65385ff

Loading...