Properly deprecate the Dependencies alias.

Review Request #3196 — Created Nov. 30, 2015 and submitted

benjyw
pants
pants-reviews
patricklaw, stuhood
I killed the Dependencies/DeprecatedDependencies dichotomy,
since we now have a proper deprecation mechanism. I left
the Dependencies name because that's the one that may still be
used externally.

CI passes: https://travis-ci.org/pantsbuild/pants/builds/94305475

  • 0
  • 0
  • 1
  • 0
  • 1
Description From Last Updated
BE
ST
  1. Thanks a lot Benjy.

  2. I think we need to break this more thoroughly immediately... since all checks for Dependencies instances have been removed, any code still using them will break in mysterious ways.

    Middle ground might be to both mark deprecated (so that we remember to remove it), and just raise an error inside this constructor.

    1. Good idea. Plus, in the ctor we know the address of the offending target, so the error will be more useful.

  3. If this is going to continue to be == to Target, it should probably have its own deprecation? Or should it just extend Dependencies and explode immediately as above.

    1. Good call. I gave it its own temporary Target subclass, so it can explode with a different error message than Dependencies.

  4. 
      
BE
ST
  1. Ship It!
  2. 
      
BE
  1. Will submit after another CI round, just in case I screwed something up.

  2. 
      
BE
BE
  1. Thanks Stu. Submitted as 79a6794d4d1a4711c1b5b93b7551747e3548f115.

  2. 
      
BE
Review request changed

Status: Closed (submitted)

Change Summary:

79a6794d4d1a4711c1b5b93b7551747e3548f115

Loading...