Fix problem with too long classpath while starting scala repl: python part

Review Request #3195 - Created Dec. 1, 2015 and submitted

Information
Timur Abishev
pants
scala_repl_too_long_python
2647
3194
3194
Reviewers
pants-reviews
peiyu, stuhood, zundel

I will write later wrap up for arg too max problem in pants in general but tl;dr is:
synthetic jar solution works for cases without custom classloaders. When custom classloaders comes to the game with their own strategy to consider classpath (using URLs from app classloader + using class.path property directly) without care much about classpath specified in jar things going to fail.

One of the cases - scala repl. So I've adopted solution with using facebook buck runner (https://github.com/facebook/buck/commit/a2070ad) to run scala repl. As runner fixes classloaders urls and class.path property it will work well with scala. As quickfix now - only for scala repl, maybe will be made more general in future.

Fix consist of two parts: java part with runner and python part for scala repl task.
This is python part.

PR: https://github.com/pantsbuild/pants/pull/2647
Java RB: https://rbcommons.com/s/twitter/r/3194/

Locally, need to publish java artifact before

Timur Abishev
Timur Abishev
Timur Abishev
Timur Abishev
Stu Hood
Timur Abishev
Stu Hood
Timur Abishev
Review request changed

Status: Closed (submitted)

Change Summary:

Merged as 3ac069cf60206ca913c0ecb891ffaf2f365118eb

Loading...