Fix problem with too long classpath while starting scala repl: java part

Review Request #3194 - Created Dec. 1, 2015 and submitted

Information
Timur Abishev
pants
scala_repl_too_long_java
2646
3195
3195
Reviewers
pants-reviews
peiyu, stuhood, zundel

I will write later wrap up for arg too max problem in pants in general but tl;dr is:
synthetic jar solution works for cases without custom classloaders. When custom classloaders comes to the game with their own strategy to consider classpath (using URLs from app classloader + using class.path property directly) without care much about classpath specified in jar things going to fail.

One of the cases - scala repl. So I've adopted solution with using facebook buck runner (https://github.com/facebook/buck/commit/a2070ad) to run scala repl. As runner fixes classloaders urls and class.path property it will work well with scala. As quickfix now - only for scala repl, maybe will be made more general in future.

Fix consist of two parts: java part with runner and python part for scala repl task.
This is java part.

PR: https://github.com/pantsbuild/pants/pull/2646
Python RB: https://rbcommons.com/s/twitter/r/3195/

https://travis-ci.org/ttim/pants/builds/94068015

Issues

  • 0
  • 10
  • 0
  • 10
Description From Last Updated
Benjy Weinberger
Benjy Weinberger
Benjy Weinberger
Benjy Weinberger
Benjy Weinberger
Nick Howard (Twitter)
Patrick Lawson
Stu Hood
Patrick Lawson
Stu Hood
Timur Abishev
Review request changed

Status: Closed (submitted)

Change Summary:

Merged as d1f66bfbb0c25e9e8978982ded15d313e5b61955; publishing shortly.

Loading...