Jvm compile counter should increment for double check cache hits

Review Request #3188 - Created Nov. 30, 2015 and submitted

Information
Dan Harrison
pants
2635
Reviewers
pants-reviews
patricklaw, stuhood, zundel
bugfix: This makes the count more accurately represents the total progress of the compile.

Moved the cache out from under pants and back in before the second check.

10:35:06 00:00         [zinc-execute]
10:35:07 00:01           [cache]   
                       No cached artifacts for 3 targets.
                       Invalidated 3 targets in 3 target partitions.> /Users/dan/4sq/pants/src/python/pants/backend/jvm/tasks/jvm_compile/jvm_compile.py(622)check_cache()
-> cached_vts, uncached_vts = self.check_artifact_cache([vts])
(Pdb) c
.
                       Hit cache during double check for examples/src/java/org/pantsbuild/example/hello/greet:greet> /Users/dan/4sq/pants/src/python/pants/backend/jvm/tasks/jvm_compile/jvm_compile.py(622)check_cache()
-> cached_vts, uncached_vts = self.check_artifact_cache([vts])
(Pdb) c
.
                       Hit cache during double check for examples/src/scala/org/pantsbuild/example/hello/welcome:welcome> /Users/dan/4sq/pants/src/python/pants/backend/jvm/tasks/jvm_compile/jvm_compile.py(622)check_cache()
-> cached_vts, uncached_vts = self.check_artifact_cache([vts])
(Pdb) c

                       [3/3] Compiling 1 zinc source in 1 target (examples/tests/scala/org/pantsbuild/example/hello/welcome:welcome).
Dan Harrison
Eric Ayers
Eric Ayers
Dan Harrison
Review request changed

Status: Closed (submitted)

Loading...