Add a helper staticmethod `closure()` to `BuildGraph`.

Review Request #3160 - Created Nov. 21, 2015 and submitted

Information
Patrick Lawson
pants
2602, 2605
Reviewers
pants-reviews
jsirois, stuhood, zundel
Add a helper staticmethod `closure()` to `BuildGraph`.

BuildGraph.closure() emulates Target.closure() but instead accepts a (potentially empty) iterable of
targets and computes their closure all at once using the efficient implementations in BuildGraph.

BuildGraph.closure() will delegate to the appropriate bfs vs dfs implementation on BuildGraph based on
the passed bfs parameter (defaults to False). It will not pass through predicates or postorder when
in dfs mode.

Because of the peeking at Target._build_graph, which is private, this isn't an ideal long-term solution--
but it's a compromise between repeating the same tricky code (which is dangerous) and repeating the same
ugly code (which is error and cargo-cult prone).

CI is green: https://travis-ci.org/pantsbuild/pants/builds/92484970

Stu Hood
Patrick Lawson
Eric Ayers
Patrick Lawson
Patrick Lawson
Review request changed

Status: Closed (submitted)

Change Summary:

Submitted at 890f05b2a29884be6d2b655d43fc260451ac08f8

Loading...