Fix `gopkg.in` fetcher to handle subpackages.

Review Request #3139 - Created Nov. 17, 2015 and submitted

Information
John Sirois
pants
jsirois/gopkg.in/debug
2581, 2583
Reviewers
pants-reviews
kwlzn, stuhood, zundel
Previously, the `gopkg.in` fetcher un-knowingly assumed import paths
would never point at subpackages inside the github repo pointed to by
the `gopkg.in` re-director protocol.  Add tests for both `root`
extraction and `fetch` for the subpackage cases and fixup the
implementation to handle these.

 contrib/go/src/python/pants/contrib/go/subsystems/fetchers.py             | 37 +++++++++++++++++++++++--------------
 contrib/go/tests/python/pants_test/contrib/go/subsystems/test_fetchers.py | 34 ++++++++++++++++++++++++++++++++++
 2 files changed, 57 insertions(+), 14 deletions(-)

Locally green:
./pants test-changed --parent=HEAD~1 --include-dependees=transitive

CI went green here:
https://travis-ci.org/pantsbuild/pants/builds/91582707

Issues

  • 0
  • 0
  • 1
  • 1
Description From Last Updated
John Sirois
Eric Ayers
John Sirois
John Sirois
Review request changed

Status: Closed (submitted)

Loading...