Move task.py out of backend/core.

Review Request #3130 — Created Nov. 15, 2015 and submitted

benjyw
pants
pants-reviews
zundel

It's a core pants concept and not part of what we
usually mean by "backend". This is a step one of
sorting out the mess in backend/core.

Points all pants code to the new location of task.py,
which is a new top-level 'task' package. A future change
will move ConsoleTask and other task-related stuff to there.

There are forwarding aliases in the original task.py, with a
deprecation warning, so external plugins shouldn't break.

CI passes: https://travis-ci.org/pantsbuild/pants/builds/92381983

ZU
  1. I see that this is the right thing to do but OMG I really hate all these API changes. When we have a catastrophic problem like we did just 12 hours ago I can't just try the latest pants to see if its fixed, I have to go mess with every single plugin.

    1. I guess what I want to know is, does this change give us any benefit in the 1.0 release? If we don't know, we need to sit down and hash out what features we are gunning for in 1.0 so we can decide which things to delay until after the cut and how to get to that cut as quickly as possible so we don't hold up progress.

    2. Just to clarify - this shouldn't break anything. I should have mentioned this in the description (and will change it appropriately) but there are forwarding aliases in the original task.py, with a deprecation warning (and I've tested that this works).

      I think this change, and others like it, are kinda necessary for 1.0 - we need a coherent API to stabilize on.

  2. 
      
BE
BE
ZU
  1. 1.0 release ideas are being finalized here: https://docs.google.com/document/d/1HDIalsQRv2Ds_uylPznX_VPmMdJib-1PdaGNVvF7fu4/edit?usp=sharing

    1. Thanks for the review, but I'll actually abandon this for now, and do this as part of a potential switch to public/_impl.

    2. Reconstituting this, since we're converging on adding an underscore as a private designator, and though these will remain public, they do still need to move out of backend/core.

  2. 
      
BE
BE
BE
BE
Review request changed

Status: Closed (submitted)

Change Summary:

aa791b02dd8525b6a18df667081ba605c9293b9d

BE
  1. Submitted as aa791b02dd8525b6a18df667081ba605c9293b9d.

  2. 
      
Loading...