Allow bundle to run for all targets, not just target roots

Review Request #3119 - Created Nov. 13, 2015 and submitted

Information
Karin Lundberg
pants
kslundberg:bundle
2558
Reviewers
pants-reviews
stuhood

Problem

We are developing an intergration test framework where we will start JVM applications from a JVM test. As part of this, we need to build the bundles for the dependent applications and to have all this happen automatically, we want to specify the jvm_app targets as dependencies for our junit_tests target.

Unfortunately, this currently doesn't work as the bundle task only runs for the target roots, not all targets so calling bundle on the junit_tests target will not call bundle for its dependencies.

Solution

Change the bundle_create task to run for all targets, not just target roots.

This is in general safe as jvm_app targets should not have dependencies themselves and targets should in general depend on library targets, not on jvm_app (or jvm_binary) targets.


  
Stu Hood
Karin Lundberg
Stu Hood
Karin Lundberg
Review request changed

Status: Closed (submitted)

Change Summary:

Merged as a285845a6907f745745e712d68f553d5d3461601

Loading...