Allow redirection of PEX's stdin/stdout/stderr.

Review Request #311 — Created May 5, 2014 and submitted

benjyw
commons
pants-reviews
jsirois
Allow redirection of PEX's stdin/stdout/stderr.

Useful for capturing output, e.g., by Pants.

Note that this is a change in twitter/commons, so I'll need someone @twitter to merge it in (I can send a github pull request for that purpose).


BE
JS
  1. LGTM - I forwarded this to Wickman to chime in and pinged him to get on the Twitter team so we can add him a a reviewer for real.
  2. 
      
BE
Review request changed

Status: Closed (submitted)

WI
  1. 
      
  2. src/python/twitter/common/python/pex.py (Diff revision 1)
     
     
    any reason to not just do **kw with the contract that all additional keyword arguments are passed to subprocess.Popen?  rather than implementing them piecemeal.
    1. I was thinking about that too under review - but now it gets pretty complex to explain - what to do when they pass preexec_fn?  You could check and raise, let the dup keyword raise, ... muddy.
  3. 
      
Loading...