Fixing malformatted xml report names from junit runner.

Review Request #3103 - Created Nov. 9, 2015 and submitted

Information
Garrett Malmquist
pants
gmalmquist/fix-sanitize-junit-runner-xml-report-names
2529
Reviewers
pants-reviews
jsirois, zundel
In https://rbcommons.com/s/twitter/r/3090/ I got the junit runner
to anticipate getting Descriptions with class names and method
names that were actually descriptions from frameworks like
cucumber. This stopped the runner from failing out with an NPE and
solved the internal use case I was checking against, but it turns
out there's another problem I overlooked (uncovered by running it
against another internal use-case).

The TestSuite names were also used to generate the filenames of the
xml reports. This does not work when the file name is some crazy
Cucumber scenario description complete with special characters and
who knows what.

So this sanitizes the name used for generating the xml file.

Extended existing integration test for cucumber to include Scenarios
that would otherwise generate bad file names, and verified that this
change fixes our internal problem.

CI went green here: https://travis-ci.org/pantsbuild/pants/builds/90160989
CI went green here: https://travis-ci.org/gmalmquist/pants/builds/90160881

Eric Ayers
Eric Ayers
Garrett Malmquist
Garrett Malmquist
Eric Ayers
Garrett Malmquist
Review request changed

Status: Closed (submitted)

Change Summary:

In commit a4a0bb0c431a4bee37df48d929a85ca02408ef18, thanks Eric!

Loading...