Fix bug when analysis file is corrupt or missing during an incremental compile

Review Request #3101 - Created Nov. 9, 2015 and submitted

Information
Eric Ayers
pants
zundel/jvm_compile_missing_analysis
2527
dbd1820...
Reviewers
pants-reviews
gmalmquist, stuhood

Somewhere between 0.0.53 and 0.0.55 this behavior changed. It looks like if the analysis file is corrupt or missing you're supposed to be able to keep going if you have --compile-zinc-clear-invalid-analysis set. The validation of the analysis file is failing with:

                     11:10:49 00:02         [zinc-execute]
                                            Invalidated 1 target.
                                            compile(squarepants/pants-aop-test-app/src/main/java:lib) failed: [Errno 2] No such file or directory: u'/Users/zundel/Development/java/.pants.d/compile/jvm/zinc/squarepants.pants-aop-test-app.src.main.java.lib/9f86810d2e79/squarepants.pants-aop-test-app.src.main.java.lib.analysis'

We have an internal plugin (invalidate_fingerprint_dependees) that is doing something extremely hacky. It does an 'rm' of the analysis file in certain cases and always triggered the above failure under 0.0.55+. After applying this patch the test case succeeds.

CI running at https://travis-ci.org/pantsbuild/pants/builds/90027725

Issues

  • 0
  • 2
  • 0
  • 2
Description From Last Updated
Stu Hood
Eric Ayers
Stu Hood
Eric Ayers
Eric Ayers
Eric Ayers
Review request changed

Status: Closed (submitted)

Change Summary:

Thanks Stu, commit 7137ea8

Loading...