Fix plugin option references in leaves.

Review Request #3098 - Created Nov. 7, 2015 and submitted

Information
John Sirois
pants
jsirois/plugins/fix_leak
2521
Reviewers
pants-reviews
benjyw, stuhood
9c2fc477 gave both `ProtobufGen` and `ZincCompile` their own `plugins`
options to not shadow the global `plugins` option, but the options
usages in those classes were not correspondingly updated.  This fixes
those usages.

 src/python/pants/backend/codegen/tasks/protobuf_gen.py              | 2 +-
 src/python/pants/backend/jvm/tasks/jvm_compile/zinc/zinc_compile.py | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)

I noticed this upgrading Medium to 0.0.56. They use the go plugin
and so have the global plugins option defined. This leads to:

...
19:39:20 00:00   [gen]
19:39:20 00:00     [thrift]
19:39:20 00:00     [protoc]
                   Invalidated 2 targets.DEBUG] Selected protoc binary bootstrapped to: /home/jsirois/.cache/pants/bin/protobuf/linux/x86_64/2.6.1/protoc

                     Executing: /home/jsirois/.cache/pants/bin/protobuf/linux/x86_64/2.6.1/protoc\
                       --java_out=/home/jsirois/dev/medium/mono/.pants.d/gen/protoc/src.main.protobuf.com.medium.proto.events.events/b9b0398038ee\
                       --pantsbuild.pants.contrib.go==0.0.56_out=/home/jsirois/dev/medium/mono/.pants.d/gen/protoc/src.main.protobuf.com.medium.proto.events.events/b9b0398038ee\
                       --proto_path=src/main/protobuf\
                       src/main/protobuf/com/medium/proto/events/events.protoUnknown flag: --pantsbuild.pants.contrib.go

19:39:20 00:00       [execute]
FAILURE: /home/jsirois/.cache/pants/bin/protobuf/linux/x86_64/2.6.1/protoc ... exited non-zero (1)


19:39:20 00:00   [complete]
               FAILURE
...

Green locally - proving no typos in the new options references
introduced:

$ ./pants test \
  tests/python/pants_test/tasks:protobuf_integration \
  tests/python/pants_test/backend/codegen/tasks:protobuf_gen \
  tests/python/pants_test/backend/jvm/tasks/jvm_compile/zinc:zinc_compile_integration

CI went green here:
https://travis-ci.org/pantsbuild/pants/builds/89771696

John Sirois
John Sirois
Stu Hood
Benjy Weinberger
Eric Ayers
John Sirois
John Sirois
Review request changed

Status: Closed (submitted)

Loading...