Move working directory outside of build root in tests

Review Request #3083 - Created Nov. 5, 2015 and submitted

Information
Timur Abishev
pants
working_directory_outside_of_build_root
2506
Reviewers
pants-reviews
stuhood

I've changed working directory to arbitrary temporary directory in both unit and integration tests.
After that I've fixed all failed tests and added one for testing our zinc analysis portability between builds with different working directories.

Also as part of this fix I've removed relativization of the paths in zinc_compile for compile classpath. I need to do this as zinc compiler doesn't handle paths with ".." well. So there is some possibility to get ARG_MAX exception while compile without nailgun, but I hope it is a rare case.

PR: https://github.com/pantsbuild/pants/pull/2506

Reviewed at https://rbcommons.com/s/twitter/r/3083/

https://travis-ci.org/ttim/pants/builds/90215049

Issues

  • 0
  • 2
  • 0
  • 2
Description From Last Updated
Timur Abishev
Benjy Weinberger
Stu Hood
Stu Hood
Timur Abishev
Review request changed

Status: Closed (submitted)

Change Summary:

Merged as df8cb6d2149d4864f71e8860cef6d224552f2519

Loading...