Fix bench goal, include integration test

Review Request #3072 - Created Nov. 3, 2015 and submitted

Information
Nick Howard (Twitter)
pants
2303, 2493
72fe79d...
Reviewers
pants-reviews
benjyw, jsirois, stuhood, zundel

The calling protocol for running java changed, but the bench task wasn't updated. This caused it to fail to work. This patch adds an integration test for bench that runs a simple benchmark in testprojects to make it harder to break in the future.

See https://github.com/pantsbuild/pants/issues/2303 for the associated error.

Wrote integration test. Saw it fail with the existing failure. Added fix. Now it passes.

Waiting on CI.

Issues

  • 0
  • 1
  • 0
  • 1
Description From Last Updated
John Sirois
Nick Howard (Twitter)
Review request changed

Status: Closed (submitted)

Change Summary:

Submitted at https://github.com/pantsbuild/pants/commit/4a9f202b9d4adaab0be5c63f475995b7ceb1f429

Eric Ayers

   

nit: don't you need to add

     'src/python/pants/java/distribution:distribution',

    'src/python/pants/java:executor',

to src/python/pants/backend/jvm/tasks/BUILD?

Loading...