Fixup NailgunClient-related OSX CI break

Review Request #3069 - Created Nov. 3, 2015 and submitted

Information
Kris Wilson
pants
kwlzn/pantsd/nailgun_client_ci_fixup
2488, 2490
4458447...
Reviewers
pants-reviews
jsirois, molsen
  • Address integration test failure/regression that disallowed NailgunClient._stdin from being None, thus causing spurious InputReader firing.

Fixes #2488

1) green w/ modified .travis.yml enabling nailguns (AFAICT): https://travis-ci.org/pantsbuild/pants/builds/88952116

2) green w/ unmodified .travis.yml: https://travis-ci.org/pantsbuild/pants/builds/88954220

3) ci.sh on local laptop:

before

[illuminati pants (master)]$ CXX=g++ ./build-support/bin/ci.sh -x -fkmsrjlpn -i 1/3 'Python integration tests for pants - shard 2'

[== 00:00 CI BEGINS: Python integration tests for pants - shard 2 ==]

00:08:29 00:01     [pytest]
00:08:29 00:01       [run]

00:08:29 00:01         [chroot]============== test session starts ===============
                     platform darwin -- Python 2.7.10 -- py-1.4.30 -- pytest-2.6.4
                     shard: 1 of 3 (0-based shard numbering)
                     plugins: timeout, cov
                     collected 228 items 
                     Only executing 76 of 228 total tests in shard 1 of 3

                     tests/python/pants_test/tasks/test_jvm_run_integration.py .
                     tests/python/pants_test/tasks/test_antlr_integration.py .
                     tests/python/pants_test/option/test_options_integration.py ..
                     tests/python/pants_test/reporting/test_reporting_integration.py ...
                     tests/python/pants_test/tasks/test_jar_publish_integration.py .....
                     tests/python/pants_test/android/tasks/test_sign_apk_integration.py s
                     tests/python/pants_test/backend/jvm/tasks/test_binary_create_integration.py ..
                     tests/python/pants_test/backend/project_info/tasks/test_idea_integration.py .........
                     tests/python/pants_test/backend/project_info/tasks/test_eclipse_integration.py ...
                     tests/python/pants_test/option/test_help_integration.py .
                     tests/python/pants_test/targets/test_jvm_app_integration.py .
                     tests/python/pants_test/java/distribution/test_distribution_integration.py .
                     tests/python/pants_test/backend/jvm/tasks/jvm_compile/zinc/test_zinc_compile_integration.py ..
                     tests/python/pants_test/backend/jvm/tasks/test_checkstyle_integration.py .
                     tests/python/pants_test/tasks/test_bootstrap_jvm_tools_integration.py .
                     tests/python/pants_test/tasks/test_junit_tests_integration.py .....
                     tests/python/pants_test/backend/core/tasks/test_markdown_to_html_integration.py .
                     tests/python/pants_test/android/tasks/test_zipalign_integration.py s
                     tests/python/pants_test/python/test_interpreter_selection_integration.py .
                     tests/python/pants_test/android/tasks/test_aapt_gen_integration.py s
                     tests/python/pants_test/base/test_spec_exclude_integration.py ..
                     tests/python/pants_test/backend/jvm/subsystems/test_shader_integration.py .
                     tests/python/pants_test/backend/jvm/tasks/jvm_compile/java/test_zinc_compile_jvm_platform_integration.py ...
                     tests/python/pants_test/tasks/test_ivy_resolve_integration.py ..
                     tests/python/pants_test/python/test_python_run_integration.py ..
                     tests/python/pants_test/backend/jvm/tasks/jvm_compile/java/test_zinc_compile_integration.py ..
                     tests/python/pants_test/tasks/test_scalastyle_integration.py .
                     tests/python/pants_test/backend/jvm/tasks/test_junit_run_integration.py ...
                     tests/python/pants_test/backend/jvm/tasks/jvm_compile/java/test_cache_compile_integration.py .
                     tests/python/pants_test/targets/test_unknown_arguments_integration.py .
                     tests/python/pants_test/backend/codegen/tasks/test_wire_integration.py ..
                     tests/python/pants_test/tasks/test_protobuf_integration.py ..
                     tests/python/pants_test/backend/jvm/tasks/test_jvm_platform_analysis_integration.py ..
                     tests/python/pants_test/backend/project_info/tasks/test_export_integration.py ....
                     tests/python/pants_test/backend/jvm/tasks/test_scala_repl_integration.py FF
                     tests/python/pants_test/backend/jvm/tasks/jvm_compile/java/test_java_compile_integration.py ..
                     tests/python/pants_test/backend/python/tasks/test_pytest_run_integration.py .

                     ==================== FAILURES ====================
                     _ ScalaReplIntegrationTest.test_run_repl_direct __

                     self = <pants_test.backend.jvm.tasks.test_scala_repl_integration.ScalaReplIntegrationTest testMethod=test_run_repl_direct>

                         def test_run_repl_direct(self):
                     >     self.assertIn('Hello, World!', self.run_repl_helloworld())
                     E     AssertionError: u'Hello, World!' not found in [u'', u'Welcome to Scala version 2.10.4 (Java HotSpot(TM) 64-Bit Server VM, Java 1.7.0_51).', u'Type in expressions to have them evaluated.', u'Type :help for more information.', u'', u'scala> ']

                     tests/python/pants_test/backend/jvm/tasks/test_scala_repl_integration.py:36: AssertionError
                      ScalaReplIntegrationTest.test_run_repl_transitive

                     self = <pants_test.backend.jvm.tasks.test_scala_repl_integration.ScalaReplIntegrationTest testMethod=test_run_repl_transitive>

                         def test_run_repl_transitive(self):
                           output_lines = self.run_repl(
                             'testprojects/src/scala/org/pantsbuild/testproject/unicode',
                             dedent("""
                                   import org.pantsbuild.testproject.unicode.shapeless.ShapelessExample
                                   println(ShapelessExample.greek())
                                 """))
                     >     self.assertIn("shapeless success", output_lines)
                     E     AssertionError: u'shapeless success' not found in [u'', u'Welcome to Scala version 2.10.4 (Java HotSpot(TM) 64-Bit Server VM, Java 1.7.0_51).', u'Type in expressions to have them evaluated.', u'Type :help for more information.', u'', u'scala> ']

                     tests/python/pants_test/backend/jvm/tasks/test_scala_repl_integration.py:53: AssertionError
                      2 failed, 71 passed, 3 skipped in 454.06 seconds

FAILURE

00:16:04 07:36   [complete]
               FAILURE

Pants Integration test failure

after

[illuminati pants (kwlzn/pantsd/nailgun_client_ci_fixup)]$ CXX=g++ ./build-support/bin/ci.sh -x -fkmsrjlpn -i 1/3 'Python integration tests for pants - shard 2'

[== 00:00 CI BEGINS: Python integration tests for pants - shard 2 ==]
...
23:59:39 00:01     [pytest]
23:59:39 00:01       [run]
                     ============== test session starts ===============
                     platform darwin -- Python 2.7.10 -- py-1.4.30 -- pytest-2.6.4
                     shard: 1 of 3 (0-based shard numbering)
                     plugins: cov, timeout
                     collected 228 items 
                     Only executing 76 of 228 total tests in shard 1 of 3

                     tests/python/pants_test/tasks/test_jvm_run_integration.py .
                     tests/python/pants_test/tasks/test_antlr_integration.py .
                     tests/python/pants_test/option/test_options_integration.py ..
                     tests/python/pants_test/reporting/test_reporting_integration.py ...
                     tests/python/pants_test/tasks/test_jar_publish_integration.py .....
                     tests/python/pants_test/android/tasks/test_sign_apk_integration.py s
                     tests/python/pants_test/backend/jvm/tasks/test_binary_create_integration.py ..
                     tests/python/pants_test/backend/project_info/tasks/test_idea_integration.py .........
                     tests/python/pants_test/backend/project_info/tasks/test_eclipse_integration.py ...
                     tests/python/pants_test/option/test_help_integration.py .
                     tests/python/pants_test/targets/test_jvm_app_integration.py .
                     tests/python/pants_test/java/distribution/test_distribution_integration.py .
                     tests/python/pants_test/backend/jvm/tasks/jvm_compile/zinc/test_zinc_compile_integration.py ..
                     tests/python/pants_test/backend/jvm/tasks/test_checkstyle_integration.py .
                     tests/python/pants_test/tasks/test_bootstrap_jvm_tools_integration.py .
                     tests/python/pants_test/tasks/test_junit_tests_integration.py .....
                     tests/python/pants_test/backend/core/tasks/test_markdown_to_html_integration.py .
                     tests/python/pants_test/android/tasks/test_zipalign_integration.py s
                     tests/python/pants_test/python/test_interpreter_selection_integration.py .
                     tests/python/pants_test/android/tasks/test_aapt_gen_integration.py s
                     tests/python/pants_test/base/test_spec_exclude_integration.py ..
                     tests/python/pants_test/backend/jvm/subsystems/test_shader_integration.py .
                     tests/python/pants_test/backend/jvm/tasks/jvm_compile/java/test_zinc_compile_jvm_platform_integration.py ...
                     tests/python/pants_test/tasks/test_ivy_resolve_integration.py ..
                     tests/python/pants_test/python/test_python_run_integration.py ..
                     tests/python/pants_test/backend/jvm/tasks/jvm_compile/java/test_zinc_compile_integration.py ..
                     tests/python/pants_test/tasks/test_scalastyle_integration.py .
                     tests/python/pants_test/backend/jvm/tasks/test_junit_run_integration.py ...
                     tests/python/pants_test/backend/jvm/tasks/jvm_compile/java/test_cache_compile_integration.py .
                     tests/python/pants_test/targets/test_unknown_arguments_integration.py .
                     tests/python/pants_test/backend/codegen/tasks/test_wire_integration.py ..
                     tests/python/pants_test/tasks/test_protobuf_integration.py ..
                     tests/python/pants_test/backend/jvm/tasks/test_jvm_platform_analysis_integration.py ..
                     tests/python/pants_test/backend/project_info/tasks/test_export_integration.py ....
                     tests/python/pants_test/backend/jvm/tasks/test_scala_repl_integration.py ..
                     tests/python/pants_test/backend/jvm/tasks/jvm_compile/java/test_java_compile_integration.py ..
                     tests/python/pants_test/backend/python/tasks/test_pytest_run_integration.py .

                     ===== 73 passed, 3 skipped in 446.25 seconds =====

00:07:06 07:28     [junit]
00:07:06 07:28     [go]
00:07:06 07:28     [npm]
00:07:06 07:28   [complete]
               SUCCESS

[== 07:35 CI SUCCESS ==]
John Sirois
Kris Wilson
John Sirois
Kris Wilson
Review request changed

Status: Closed (submitted)

Change Summary:

thanks John & Matt. submitted @ ae5fd47795bcb217f81ad8c346f2d46786189af4

Loading...