Break out core runtime logic into a PantsRunner

Review Request #3054 - Created Oct. 29, 2015 and submitted

Information
Kris Wilson
pants
kwlzn/pantsd/pants_runner
2469
8745c14...
Reviewers
pants-reviews
benjyw, jsirois, nhoward_tw, stuhood, zundel

This change sets us up for different methods/modes of running pants. Expect two subsequent PantsRunner variants to follow: DaemonPantsRunner (a subclass of LocalPantsRunner that runs in the daemon/nailgunned context) and ThinPantsRunner (a nailgun-client PantsRunner).

  • Introduce PantsRunner ABC.
  • Break out current pants_exe.py logic into LocalPantsRunner + Exiter.
  • Plumb Exiter usage all the way through to GoalRunner.

1) CI green @ https://travis-ci.org/pantsbuild/pants/builds/88187104

2) PANTS_DEV=1 ./pants clean-all binary examples/src/java:: -> works

3) PANTS_PROFILE=/tmp/xyz.out PANTS_DEV=1 ./pants clean-all binary examples/src/java:: -> works and produces expected profiling output

Stu Hood
Eric Ayers
Kris Wilson
Stu Hood
Kris Wilson
Review request changed

Status: Closed (submitted)

Change Summary:

thanks Stu, Eric & John! submitted @ bd0a85deef1abb21022b00e8999b47ba1f8ab600

Loading...