Preparation to moving workdir outside of build root

Review Request #3050 - Created Oct. 29, 2015 and submitted

Information
Timur Abishev
pants
preparation_to_moving_workdir_outside_of_build_root
2468
4224101...
Reviewers
pants-reviews
stuhood

I'm currently working on moving working directory (pants_workdir) outside of build root.

I've decided to divide work into two separate parts: preparation and main part. For preparation I want to:
1) get single point (field) for working directory in tests (both unit and integration), now it's BaseTest#pants_workdir and PantsRunIntegrationTest#workdir_root.
2) fix issues with working directories in tests (i.e. relying on BUILD_ROOT/.pants.d working directory structure in tests code)
3) fix wrong assumptions in new environment (i.e. assertion like class path entries should be in build root or clean-all can operate only on build root content)

For second part I want to change single point for working directory to arbitrary one and fix tests after that, also I want to take a look into all ".pants.d" usages and portable version of zinc analysis file.

This review contains preparation part.

Testing Done: https://travis-ci.org/ttim/pants/builds/88250547

PR: https://github.com/pantsbuild/pants/pull/2468

Reviewed at https://rbcommons.com/s/twitter/r/3050/


  

Issues

  • 0
  • 1
  • 0
  • 1
Description From Last Updated
Timur Abishev
Stu Hood
Timur Abishev
Stu Hood
Timur Abishev
Timur Abishev
Timur Abishev
Review request changed

Status: Closed (submitted)

Change Summary:

Merged as 4fe1888b1137c4812d38fa92a8ff8b62ea6b9d0f

Eric Ayers

FYI, Some of our tasks / tests started to fail in 0.0.56. I've filed an RB for a minor change to this code: https://rbcommons.com/s/twitter/r/3099/

  1. Looks good for me

Loading...