Clean up corrupted local cache for errors that are not retryable

Review Request #3045 - Created Oct. 28, 2015 and submitted

Information
Peiyu Wang
pants
peiyuwang:peiyu/clean-up-corrupted-local-artifact
2464
5d6b5e6...
Reviewers
pants-reviews
davidt, fkorotkov, patricklaw, stuhood

Saw a bunch "CRC check failed" errors, it's ok for downloads to fail, but it's
not ok to leave the corrupted artifacts in local cache. Because most of such
errors are non-retryable, and if we don't clean up bad artifacts, next time (we
still from time to time need clean-all) will be a cache hit first but then fail
the check and do the compile again. As you can see most if not all tarfile.ReadError
and IOError from gzip are not retryable

https://travis-ci.org/peiyuwang/pants/builds/87716343

Peiyu Wang
Stu Hood
Peiyu Wang
Patrick Lawson
Stu Hood
Peiyu Wang
Review request changed

Status: Closed (submitted)

Change Summary:

Merged as f2db068e1ad70bc1765b3526e8daa4f6086449a1

Loading...