Fix issue with trailing newline

Review Request #3033 - Created Oct. 24, 2015 and submitted

Information
Matt Olsen
pants
2445, 2451
fbf6ddf...
Reviewers
pants-reviews
stuhood
In checkstyle lines were split with str.splitlines(), this removed trailing empty strings
at the end of the file.  This caused index errors when a file had trailing blank lines.

Code has been updated to use split('\n') and the unit tests updated to catch this.

fix some unicode issues


remove cache file


remove debug print

build is green, added a new test to check for the extra blank line.

https://travis-ci.org/pantsbuild/pants/builds/87158033

Stu Hood
Matt Olsen
Matt Olsen
Matt Olsen
Review request changed

Status: Closed (submitted)

Change Summary:

Merged as dd9d7ec6f38eceba49a50a1f5158afcc0f7df7a8

In future, please use titles that are ready to go directly into the release notes (...because they do!)

Loading...