Add a fixed source root for the go_remote dir in contrib/go.

Review Request #3027 — Created Oct. 22, 2015 and submitted

benjyw
pants
f365ab7...
pants-reviews
jsirois
This ensures that go_buildgen will run on the contrib/go/examples.

It also demonstrates how go repos can do the same in their pants.ini
(until we make 3rdparty/remote source roots a first-class entity,
like src and test, after which this hack will no longer be necessary).

CI passed here: https://travis-ci.org/pantsbuild/pants/builds/86972080.

JS
  1. Thanks Benjy.
  2. It's a wart, but it would be nice to manually keep the comments by rejecting the buildgen.go induced diff for this BUILD and the next.

    1. Oh, I had no idea if these were supposed to be checked in or what. I just assumed that these were generated and therefore correct as-is. I didn't even look at the diffs. What was the right course of action here?

    2. Revert for these two.  The re-gen is dumb simple right now and does not preserve comments.  Ideally it would.  These comments are moderately important.
  3. 
      
BE
BE
BE
Review request changed

Status: Closed (submitted)

Change Summary:

cd0ce6f5ae50f10ebdb7ca024a3e4bd4c840e08c

Loading...