Rearrange the goal registration code.

Review Request #301 — Created April 30, 2014 and submitted

benjyw
pants
pants-reviews
jsirois
- Now goal.py is just the goal command.
- goal/register.py registers the goals.
- Some inline task classes now have their own proper homes.
ci.sh

bootstrapping

Various compiles.
JS
  1. LGTM, please just fix the 100 cols
  2. src/python/pants/commands/goal.py (Diff revision 1)
     
     
    YAY
  3. src/python/pants/tasks/clean.py (Diff revision 1)
     
     
    I'm pretty sure realpath does an abspath already as part of its work.  Although this may be just for posixpath.  Its certainly not clear in the stdlib docs.
  4. src/python/pants/tasks/clean.py (Diff revision 1)
     
     
    I'm happy to see it go.
  5. no \ - you're in parens - also please re-flow - these are >100
    1. Fixed. But I left the handful of > 100 cases in register.py. There I felt that, given the boilerplatiness, uniformity within the file, having a single way to format a goal() stanza, was more important. 
  6. 
      
BE
Review request changed

Status: Closed (submitted)

Loading...