doc += for a deploy-able pile o' files, make a jvm_app with no Main

Review Request #30 — Created Feb. 27, 2014 and submitted

lahosken
commons
pants-reviews
travis
based on a question+answer on a Twitter internal mail thread


  • 1
  • 0
  • 0
  • 0
  • 1
Description From Last Updated
Looking at https://github.com/twitter/commons/blob/master/src/python/twitter/pants/targets/jvm_binary.py#L181 I believe jvm_app requires a binary. Can you check if this actually works? We might need a ... TR travis
LA
LA
TR
  1. 
      
  2. Looking at https://github.com/twitter/commons/blob/master/src/python/twitter/pants/targets/jvm_binary.py#L181 I believe jvm_app requires a binary. Can you check if this actually works? We might need a separate target type to support this.
    1. Good question! Bundles act funny right now. I'll poke around some and come up with a report more useful than "act funny"
    2. OK, corrected. It's not a main-less jvm_app. It's a jvm_app with a main-less jvm_binary.
      
      In an alternate universe in which bundles work at all, this gives you a bundle of files.
  3. 
      
LA
TR
  1. If this works I'm fine doc'ing reality. This feels a bit awkward though - maybe we need to think about additional *_app target types.
  2. 
      
LA
  1. Thanks, folks. Pushed. Will publish soon.
    
    > maybe we need to think about additional *_app target types.
    
    Yep, the JVM-ness feels weird here.
  2. 
      
LA
Review request changed

Status: Closed (submitted)

Loading...