Prepare the 1st test for the new engine front end.

Review Request #2988 - Created Oct. 18, 2015 and submitted

Information
John Sirois
pants
jsirois/engine/exp/seed_inputs
2308, 2365
2989
e3041cb...
Reviewers
pants-reviews
benjyw, ity, mateor, nhoward_tw, patricklaw, stuhood
This introduces a simple codegen graph and establishes a test skeleton.
A more complete representation for `Sources` is also added as well as
hardening `Configuration`'s `__hash__`/`__eq__` to deal with a wider
range of `Configuration` values.

 src/python/pants/engine/exp/BUILD                                                                    |   1 +
 src/python/pants/engine/exp/addressable.py                                                           |  58 ++++++++++++----
 src/python/pants/engine/exp/configuration.py                                                         |  29 +++++---
 src/python/pants/engine/exp/parsers.py                                                               |  14 ++--
 src/python/pants/engine/exp/targets.py                                                               | 188 +++++++++++++++++++++++++++++++++++---------------
 tests/python/pants_test/engine/exp/BUILD                                                             |  20 +++++-
 tests/python/pants_test/engine/exp/examples/graph_test/self_contained.BUILD                          |   6 +-
 tests/python/pants_test/engine/exp/examples/graph_test/self_contained.BUILD.json                     |   5 +-
 tests/python/pants_test/engine/exp/examples/graph_test/self_contained.BUILD.python                   |   7 +-
 tests/python/pants_test/engine/exp/examples/mapper_test/a/b/b.BUILD.json                             |   1 -
 tests/python/pants_test/engine/exp/examples/scheduler_inputs/3rdparty/jvm/BLD.json                   |   6 ++
 tests/python/pants_test/engine/exp/examples/scheduler_inputs/src/java/codegen/simple/BLD.json        |  11 +++
 tests/python/pants_test/engine/exp/examples/scheduler_inputs/src/java/codegen/simple/Simple.java     |   1 +
 tests/python/pants_test/engine/exp/examples/scheduler_inputs/src/thrift/BLD.json                     |  33 +++++++++
 tests/python/pants_test/engine/exp/examples/scheduler_inputs/src/thrift/codegen/simple/BLD.json      |   8 +++
 tests/python/pants_test/engine/exp/examples/scheduler_inputs/src/thrift/codegen/simple/simple.thrift |   1 +
 tests/python/pants_test/engine/exp/test_addressable.py                                               |  60 +++++++++-------
 tests/python/pants_test/engine/exp/test_graph.py                                                     |  61 +++++++++++++---
 tests/python/pants_test/engine/exp/test_parsers.py                                                   |  79 +++++++++++----------
 tests/python/pants_test/engine/exp/test_scheduler.py                                                 | 123 +++++++++++++++++++++++++++++++++
 20 files changed, 543 insertions(+), 169 deletions(-)
CI went green here:
  https://travis-ci.org/pantsbuild/pants/builds/85982429
John Sirois
John Sirois
John Sirois
Review request changed

Status: Closed (submitted)

Benjy Weinberger

   
src/python/pants/engine/exp/targets.py (Diff revision 1)
 
 

Can we just standardize on one globs language and be done with it?

  1. I'd like to, but certainly not during the transition to the new engine!  If folks don't use zglobs we can drop, but I'm sure they use rglobs, so there will be a transition period.  I'd love to decouple new engine migration from that transition.
Loading...