Switch all internal code to use the new source roots mechanism.

Review Request #2987 - Created Oct. 17, 2015 and submitted

Information
Benjy Weinberger
pants
6ad7191...
Reviewers
pants-reviews
jsirois, stuhood

In particular, have tests use standard source root names that
match the default patterns, so we don't need to explicitly register
source roots in tests.

Required a couple of hacks to set up the SourceRootConfig
subsystem in a handful of tests that don't use BaseTest.context().
We really need to find a more straightforward way to set up tests.
Hopefully the new engine will remove the need for so much implicit
global state.

The changes are mostly mundane, but there a few files to pay particular
attention to:

- source_root.py
- context.py
- base_test.py
- go_buildgen.py (and other go-related files)
- maven_layout.py

CI passes (after many trial-and-error iterations): https://travis-ci.org/pantsbuild/pants/builds/85874775

CI still passes after code review iteration: https://travis-ci.org/pantsbuild/pants/builds/86257544.

Issues

  • 0
  • 1
  • 1
  • 2
Description From Last Updated
Benjy Weinberger
Benjy Weinberger
Stu Hood
Benjy Weinberger
Benjy Weinberger
Benjy Weinberger
Review request changed

Status: Closed (submitted)

Change Summary:

570690f2974a698afee90026f4275da375cb5d4e

Loading...