Prepare the 0.0.54 release.

Review Request #2982 — Created Oct. 16, 2015 and submitted

patricklaw
pants
2387
195ed44...
pants-reviews
benjyw, jsirois, stuhood, zundel
Prepare the 0.0.54 release.

CI is green: https://travis-ci.org/pantsbuild/pants/builds/85838320

JS
  1. This should break hard, an RB will need to go out 1st eliminating these deprecations or else you need to bump them to 0.0.55:

    $ git grep "0.0.54"
    src/python/pants/backend/jvm/register.py:@deprecated(removal_version='0.0.54', hint_message="Replace 'Repository' with 'repository'.")
    src/python/pants/backend/jvm/targets/jar_dependency.py:  @deprecated(removal_version='0.0.54',
    src/python/pants/backend/jvm/targets/jar_dependency.py:  @deprecated(removal_version='0.0.54',
    src/python/pants/base/build_file_aliases.py:deprecated_module('0.0.54', hint_message='Use pants.build_graph.build_file_aliases instead.')
    src/python/pants/base/target.py:deprecated_module('0.0.54', hint_message='Use pants.build_graph.target instead.')
    
  2. 
      
ST
  1. Thanks!

    1. I appreciate the thorough corrections, but in general I think these corrections should have been made on the original CR if they're not sufficiently descriptive titles for a release. We should lean on our automation for this kind of thing.

    2. +1 to not correcting commit subject lines on release, but instead in review.
  2. src/python/pants/CHANGELOG.rst (Diff revision 1)
     
     

    "... to scan an explicitly passed root"
    I think?

  3. src/python/pants/CHANGELOG.rst (Diff revision 1)
     
     

    statements

    Also, this one probably counts as a refactor

  4. src/python/pants/CHANGELOG.rst (Diff revision 1)
     
     

    Mention pypi here?

  5. 
      
PA
JS
  1. 
      
  2. src/python/pants/CHANGELOG.rst (Diff revisions 1 - 2)
     
     
    This is fine since you added a note, but a saner strategy in general is to do removals as a seperate RB to let their CHANGELOG entry be a normal `API Changes` entry.  I meant what I said in my 1st RB comment!
  3. 
      
ST
  1. Ship It!
  2. 
      
JS
  1. 
      
  2. src/python/pants/CHANGELOG.rst (Diff revision 2)
     
     
    Aha - burned by copypasta and s/9/16/ - needs an extra '-' to line up.
  3. 
      
PA
JS
  1. Ship It!
  2. 
      
PA
PA
Review request changed

Status: Closed (submitted)

Change Summary:

Submitted at: bf5e1d8998802c3c61d1bc3d47b0e62cf7b3808e

Thanks everyone!

Loading...