Fix timeout implementation by adding abort handlers

Review Request #2979 - Created Oct. 16, 2015 and submitted

Information
Sameer Brenn
pants
b154728...
Reviewers
pants-reviews
benjyw, jsirois, kwlzn, stuhood

Fixes a bug with the timeouts implementation

Bug: If a test takes too long, the timeout is triggered and it fails, but it still runs — ie it isn’t aborted, and the test still takes a long time to run.

Soln: Creates a _timeout_abort_handler abstract callback in the mixin that must be implemented by the test runner class.

./pants test tests/python/pants_test/util:timeout
./pants test tests/python/pants_test:all

New integration tests added:

./pants test tests/python/pants_test/backend/python/tasks:pytest_run_integration
./pants test tests/python/pants_test/backend/jvm/tasks:junit_run_integration

PR: https://github.com/pantsbuild/pants/pull/2397

Issues

  • 1
  • 7
  • 1
  • 9
Description From Last Updated
It's really clunky that what was previously local information (the executor/process handle) now has to be part of the mutable ... Benjy Weinberger Benjy Weinberger
Itay Donanhirsh
Sameer Brenn
Stu Hood
Sameer Brenn
Benjy Weinberger
Stu Hood
Benjy Weinberger
Benjy Weinberger
Sameer Brenn
Review request changed

Status: Closed (submitted)

Change Summary:

Merged as a97ce6ec37a9e122423934551239c39e962c8ff5

Loading...